----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/632/#review992 -----------------------------------------------------------
In Plasma kdelibs coding style is used.. please refer to this document and restyle your code: http://techbase.kde.org/Policies/Kdelibs_Coding_Style You can remove those sources you didn't modify from the diff.. trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp <http://reviewboard.kde.org/r/632/#comment672> avoid blank spaces.. anyway remove this file from the diff since you didn't edit it :) trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.h <http://reviewboard.kde.org/r/632/#comment676> you can default the parent to 0 here trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.cpp <http://reviewboard.kde.org/r/632/#comment673> what is this needed for? trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.cpp <http://reviewboard.kde.org/r/632/#comment674> generally prefer kDebug() to qDebug() trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp <http://reviewboard.kde.org/r/632/#comment675> also the default class implementation should be called, no? trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp <http://reviewboard.kde.org/r/632/#comment677> you can reimplement the sizeHint method to have more space available and paint the bar lower.. in addition to this you could try to paint it only on mouse hover - Alessandro On 2009-04-26 05:16:04, mck182 wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/632/ > ----------------------------------------------------------- > > (Updated 2009-04-26 05:16:04) > > > Review request for Plasma. > > > Summary > ------- > > This is more like a proof of concept, for me to see if I'm on the right way > with this one > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h > 958067 > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp > 958067 > > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp > PRE-CREATION > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h > 958067 > > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp > 958067 > > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.cpp > PRE-CREATION > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt > 958067 > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h > 958067 > > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp > 958067 > trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.h > PRE-CREATION > > Diff: http://reviewboard.kde.org/r/632/diff > > > Testing > ------- > > > Thanks, > > mck182 > > _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
