----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/789/#review1255 -----------------------------------------------------------
The idea is quite nice, however I see a problem here: connect(runnerManager, SIGNAL(matchesChanged(const QList<Plasma::QueryMatch> &)), SLOT(stopProgressWidget())); in fact matchesChanged might be called several times during a query, especially if the user has enabled ``slow'' runners (e.g. nepomuk). This implies that the progresswidget would stop before the query has actually finished, which is not accurate. I haven't thought about it too much, but I believe that if you want to provide such functionality you have to modify runnerManager to emit a signal when all runners have finished, which may not be completely trivial. - Jacopo On 2009-06-02 03:06:37, jgoday wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/789/ > ----------------------------------------------------------- > > (Updated 2009-06-02 03:06:37) > > > Review request for Plasma. > > > Summary > ------- > > Display a progress widget in krunner while performing the > krunnermanager->query > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 976186 > /trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp > 976186 > > Diff: http://reviewboard.kde.org/r/789/diff > > > Testing > ------- > > > Screenshots > ----------- > > krunner > http://reviewboard.kde.org/r/789/s/127/ > > > Thanks, > > jgoday > > _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
