----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1253/#review1953 -----------------------------------------------------------
Ship it! Code looks clean and correct, nice work :) I really, really tried to find things wrong with it, but couldn't find anything worse than a bit of stray whitespace in the license header. Go for it. /trunk/KDE/kdeplasma-addons/applets/opendesktop/activitywidget.h <http://reviewboard.kde.org/r/1253/#comment1311> stray whitespace :) - Sebastian On 2009-08-10 10:54:19, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1253/ > ----------------------------------------------------------- > > (Updated 2009-08-10 10:54:19) > > > Review request for Plasma. > > > Summary > ------- > > no, not plasma activities :p > this adds the friends activity support to the opendesktop plasmoid and > selects it by default, so it doesn't look as a static thing anymore but shows > some "news" > > still to do: > configurable refresh time > avatar pictures to make it more kolorful > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/opendesktop/CMakeLists.txt 1009325 > /trunk/KDE/kdeplasma-addons/applets/opendesktop/activitywidget.h > PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/opendesktop/activitywidget.cpp > PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/opendesktop/opendesktop.h 1009325 > /trunk/KDE/kdeplasma-addons/applets/opendesktop/opendesktop.cpp 1009325 > > Diff: http://reviewboard.kde.org/r/1253/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/1253/s/170/ > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel