> On 2009-03-29 05:27:41, Marco Martin wrote: > > looks good. > > i would skip the select all button for now
this is submitted, can somebody mark it as that? - Beat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/461/#review685 ----------------------------------------------------------- On 2009-04-07 06:09:38, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/461/ > ----------------------------------------------------------- > > (Updated 2009-04-07 06:09:38) > > > Review request for Plasma and Davide Bettio. > > > Summary > ------- > > Whenever the user ticks "Use Tabs" the view changes and the available comics > are displayed in a listview, clicking at them marks them and adds them as > tabs if ok is pressed. Otherwise it is similar to the current situation. > > I'm not sure if I should add "Select All"-, "Deselect All"-Buttons. What do > you think? > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/comic/appearanceSettings.ui 950532 > /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 950532 > /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 950532 > /trunk/KDE/kdeplasma-addons/applets/comic/comicSettings.ui 950532 > /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 950532 > /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 950532 > > Diff: http://reviewboard.kde.org/r/461/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/461/s/99/ > > http://reviewboard.kde.org/r/461/s/100/ > > http://reviewboard.kde.org/r/461/s/102/ > > > Thanks, > > Matthias > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
