-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1709/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

If the view is arranged (i.e. m_layoutBroken is false), the icons between the 
previous and the current click are selected linearly. If the view is broken, 
the icons which are in the rectangular region of the previous and currently 
selected icon, are selected. This is because when the view is broken, there is 
no 'linearity' as such.
A minor change to key functionality - If more than one icon is selected when a 
key is pressed (so we need to deselect those), then it needs to repaint the 
whole visible area. It could have iterated over all selected icons and repaint 
them, but the previous approach looks simpler. I'm not sure which of these is 
faster though, some hints please ..


This addresses bug 189359.
    https://bugs.kde.org/show_bug.cgi?id=189359


Diffs
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1027710 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1027710 

Diff: http://reviewboard.kde.org/r/1709/diff


Testing
-------

Tested on current trunk build. Works fine.


Thanks,

Shantanu

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to