----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1821/#review2607 -----------------------------------------------------------
Ship it! other than the cost'ness issues in the method signatures, this looks good to go. fix those up and then please commit :) /trunk/KDE/kdelibs/plasma/wallpaper.h <http://reviewboard.kde.org/r/1821/#comment1939> should be contextualActions() const; /trunk/KDE/kdelibs/plasma/wallpaper.h <http://reviewboard.kde.org/r/1821/#comment1940> const QList<QAction*> &actions - Aaron On 2009-10-11 14:16:33, Yuen Hoe Lim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1821/ > ----------------------------------------------------------- > > (Updated 2009-10-11 14:16:33) > > > Review request for Plasma. > > > Summary > ------- > > (I can't get my changes in kdebase and kdelibs into the same diff, so this is > 'diff 1 of 2', with the kdelibs changes) > > Adds support for wallpaper plugins to specify their own contextual actions > that will be added to the containment context menu. These wallpaper > contextual actions can be enabled/disabled like any other contextual actions > via the mouse plugin context menu configuration ui (by checking/unchecking > 'Wallpaper Actions'). > > Also adds a 'Next Wallpaper Image' contextual action for the image wallpaper > plugin using this new support. This functionality only activates when image > plugin is in 'slide show' mode (and of course if it is enabled in the mouse > plugin ui). > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/wallpaper.h 1033391 > /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1033391 > > Diff: http://reviewboard.kde.org/r/1821/diff > > > Testing > ------- > > Built and briefly tested the functionalities mentioned in the description - > they work fine as far as I can tell. > > > Thanks, > > Yuen Hoe > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
