-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1822/#review2624
-----------------------------------------------------------

Ship it!



/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://reviewboard.kde.org/r/1822/#comment1950>

    ohhhh. good point.


- Chani


On 2009-10-11 14:16:47, Yuen Hoe Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1822/
> -----------------------------------------------------------
> 
> (Updated 2009-10-11 14:16:47)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> (I can't get my changes in kdebase and kdelibs into the same diff, so this is 
> 'diff 2 of 2', with the kdebase changes)
> 
> Adds support for wallpaper plugins to specify their own contextual actions 
> that will be added to the containment context menu. These wallpaper 
> contextual actions can be enabled/disabled like any other contextual actions 
> via the mouse plugin context menu configuration ui (by checking/unchecking 
> 'Wallpaper Actions').
> 
> Also adds a 'Next Wallpaper Image' contextual action for the image wallpaper 
> plugin using this new support. This functionality only activates when image 
> plugin is in 'slide show' mode (and of course if it is enabled in the mouse 
> plugin ui).
> 
> 
> Diffs
> -----
> 
>   
> /trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/contextmenu/menu.cpp
>  1033402 
>   /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 
> 1033402 
>   /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 
> 1033402 
> 
> Diff: http://reviewboard.kde.org/r/1822/diff
> 
> 
> Testing
> -------
> 
> Built and briefly tested the functionalities mentioned in the description - 
> they work fine as far as I can tell.
> 
> 
> Thanks,
> 
> Yuen Hoe
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to