----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1840/ -----------------------------------------------------------
(Updated 2009-10-13 20:48:15.795082) Review request for Plasma. Changes ------- this tries to implement the evil eventfilters-works-the-opposite-way type of thing. works the opposite way because the event arrives, the filter catches it, it send it back to the filtered widget and then does its operations on it. this way the webview can block the scrolling if it wants to select text instead. this will expose a nice api, but oh boy the price is code really nasty, is it worth it? Summary ------- this is just an experiment that has perhaps a too big disadvantage to be practical... makes use of event filters instead of explicitly forwarding mouse events. the advantage is that it would be super easy to use and woouldn't be needed to export new classes in plasma, there could just be an Animator::registerScrollingManager(QGraphicsWidget *) function the big disadvantage is that is less controllable, so widgets can't decide to -not- make use of the kineticscrolling, thing that is quite needed in WebView. Diffs (updated) ----- /trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1034839 /trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1034839 /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1034839 /trunk/KDE/kdelibs/plasma/widgets/webview.h 1034839 /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1034839 Diff: http://reviewboard.kde.org/r/1840/diff Testing ------- Thanks, Marco _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
