> On 2009-10-19 14:08:39, Adenilson Cavalcanti wrote: > > Maybe it will make users confused to add new features in a deprecated class > > (I guess this sends the wrong message about it being deprecated). > > > > Why instead of having a central scroll manager (with a container of > > scrollers), to use the current Animator interface and do something like > > this: > > Animation *kineticScroller = new Plasma::AnimatorFactory(KineticScroller); > > kineticScroller->setWidget(the_object_to_scroll); > > > > and setting it as the kineticscroller parent (so it will get deleted > > together with the scrolled widget)? > > > > When we implement the factory, all other animation classes could be even in > > the 'private' folder (so no need to export new classes). > > > > What do you think? > > :-) > >
Animator is not a deprecated class per se, just all its current functions are... about makig it a subclass of animation> no i don-t think is a good idea, since it-s not -an- animation - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1892/#review2714 ----------------------------------------------------------- On 2009-10-19 12:59:46, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1892/ > ----------------------------------------------------------- > > (Updated 2009-10-19 12:59:46) > > > Review request for Plasma. > > > Summary > ------- > > provide the Animator::registerScrollingManager(qgraphicsidget) function. > the animator creates a kineticscroll and associates it with the widget. in > this way we can use kineticscroll outside of libplasma with a single call. > another option would be to export kineticscroll with just the constructor and > nothing else but i don't like it so much, unless it could make sense the > behaviour of kineticscroll could be controlled with some methods (i would > like it as less controllable as possible). > > Do we want to totally deprecate Animator or still be able to provide > functions to it? (in this case the implementation should be moved outside of > deprecated and a -second- dpointer should be provided) > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/animator.h 1037518 > /trunk/KDE/kdelibs/plasma/deprecated/animator.cpp 1037518 > /trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1037518 > /trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1037518 > /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1037518 > /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1037518 > > Diff: http://reviewboard.kde.org/r/1892/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
