On Monday 02 November 2009 13:53:35 Sebastian Kügler wrote: > On Monday 02 November 2009 13:24:03 Jan Gerrit Marker wrote: > > Am Montag 02 November 2009 10:24:05 schrieb Marco Martin: > > > hmm, not sure if having something installed by default specific for > > > firefox would be a soo good idea, what would be cool is having a single > > > bookmark runner that would search in firefox if it's the default > > > browser otherwise in konqueror as usual. > > > would it have a too convoluted logic? > > > > > > You could have two methods: > > QList<Plasma::QueryMatch> firefoxBookmarks(QString& term); > > QList<Plasma::QueryMatch> konquerorBookmarks(QString& term); > > > > The match Method tests if Firefox or Konqueror should be asked for > > bookmark information and runs the methods. Then it calls > > context.addMatches() and adds the matches it got from the method. > > > > But the idea of a single bookmark runner is good. That would be much > > easier. > > I (as the original developer of the konqi bookmark runner) think it's a > good idea.
Just occurred to me that this isn't true. :D I've been doing the history runner, not the bookmarks one (but touched the code at some point, IIRC). -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel