----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2091/#review3064 -----------------------------------------------------------
the line edit for the single query mode should probably have a click text that comes from the name or description of the runner being used; maybe it would even be useful to put a label next to the icon with the name of the runner, so it's really evident what's going on? trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml <http://reviewboard.kde.org/r/2091/#comment2492> perhaps "querySingleRunner"? trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp <http://reviewboard.kde.org/r/2091/#comment2493> if (singleRunnerMode()) { } else if (!term.isEmpty()) { } might be a bit clearer to read trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp <http://reviewboard.kde.org/r/2091/#comment2496> adjustInterface(bool) is redundant; may as well just have one method, setStaticQueryMode(bool) trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp <http://reviewboard.kde.org/r/2091/#comment2490> please watch the whitespace inside of ()s .. :) trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp <http://reviewboard.kde.org/r/2091/#comment2491> isn't that a no-op due to: void KRunnerApp::singleRunnerMode(const QString& runnerName) { if ( runnerName.isEmpty() ) { return; - Aaron On 2009-11-07 20:29:26, Jacopo De Simoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2091/ > ----------------------------------------------------------- > > (Updated 2009-11-07 20:29:26) > > > Review request for Plasma, Aaron Seigo and Ryan Bitanga. > > > Summary > ------- > > This patch adds single runner query support to krunner; > When loading the runners, if any runner supports a defaultSyntax, then this > is exposed via an action which shows up in the global shortcuts; > When this action is triggered, krunner starts in single-runner-query mode; > i.e. queries are processed by the selected runner only; the interfaces > changes slightly to reflect this fact (screenshot) and the query given by > the default syntax is automatically run. > > Also a convenient dbus interface is added, in case we want to trigger this > internally; > > The most obvious usecase is the windows runner; an upcoming devicerunner and > also the nepomuk search runner could make use of this feature. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/krunner/dbus/org.kde.krunner.App.xml 1046190 > trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1046190 > trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp > 1046190 > trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp > 1046190 > trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.h > 1046190 > trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_dialog.cpp > 1046190 > trunk/KDE/kdebase/workspace/krunner/krunnerapp.h 1046190 > trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1046190 > trunk/KDE/kdebase/workspace/krunner/krunnerdialog.h 1046190 > trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1046190 > > Diff: http://reviewboard.kde.org/r/2091/diff > > > Testing > ------- > > > Screenshots > ----------- > > Window runner in single runner mode > http://reviewboard.kde.org/r/2091/s/255/ > > > Thanks, > > Jacopo > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel