----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2990/#review4192 -----------------------------------------------------------
Ship it! i think this is really a must have and should go in. two micro issues below, but i'm generally favorable to this /trunk/KDE/kdelibs/plasma/private/animablegraphicswebview.cpp <http://reviewboard.kde.org/r/2990/#comment3701> dead things here, a blank trailing space the row above:) /trunk/KDE/kdelibs/plasma/widgets/webview.cpp <http://reviewboard.kde.org/r/2990/#comment3702> thing that we were talking about the other day: are you sure nw that page() and mainFrame() are always valid? - Marco On 2010-02-17 02:46:46, Davide Bettio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2990/ > ----------------------------------------------------------- > > (Updated 2010-02-17 02:46:46) > > > Review request for Plasma. > > > Summary > ------- > > This patch replaces all the old code that uses directly KWebPage with new > code that uses KGraphicsWebView. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/widgets/webview.h 1090797 > /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1090803 > /trunk/KDE/kdelibs/plasma/private/animablegraphicswebview_p.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1090803 > /trunk/KDE/kdelibs/plasma/private/animablegraphicswebview.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/2990/diff > > > Testing > ------- > > > Thanks, > > Davide > > _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
