bruns added inline comments.
INLINE COMMENTS
> ivan wrote in GtkEventSpy.cpp:126
> No need to compare chars with strings:
>
> if (!exec.isEmpty() && exec[0] == '\'' && exec.back() == '\'')
missing `QChar('\'')`, otherwise it breaks with QT_NO_CAST_FROM_ASCII
-> `if (exec.startsWith(QChar('\'') && exec.endsWith(QChar('\'')) {...`
> GtkEventSpy.cpp:144
> + // remove space and any caracter after
> + const int spaceIdex = exec.indexOf(" ");
> + if (spaceIdex != -1) {
`spaceI_n_dex`
REPOSITORY
R161 KActivity Manager Service
REVISION DETAIL
https://phabricator.kde.org/D23112
To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
