davidedmundson added inline comments.
INLINE COMMENTS
> network.cpp:74
> + const auto parts = line.splitRef(QLatin1Char('|'),
> QString::SkipEmptyParts);
> + if (parts.size() < 2)
> + continue;
why 2? We call parts.at(6)
Also code style {}
> network.h:28-29
> +
> +class NetworkSensor;
> +class ApplicationNetworkSensor;
> +
These can go go now
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D23342
To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
