davidedmundson added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:80
>      // create SDDM config directory if it does not exist
>      QDir 
> sddmConfigLocation(args[QStringLiteral("sddmUserConfig")].toString());
>      if (!sddmConfigLocation.exists()) {

can we use sddmHomeDirPath + "whatever"

instead now

and get rid of this sddmUserConfig map entry

> sddmauthhelper.cpp:172
> +
>      QDir 
> sddmConfigLocation(args[QStringLiteral("sddmUserConfig")].toString());
>      QDir fontconfigDir(args[QStringLiteral("sddmUserConfig")].toString() + 
> QStringLiteral("/fontconfig"));

and here

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to