davidedmundson added a comment.

  Generally seems ok. Two minor comments.

INLINE COMMENTS

> main.qml:238
> +                        _iconName: "edit-redo"
> +                        _text: i18nd("libplasma5", "Redo")
> +                        onTriggered: contextMenu.retFocus(() => 
> mainTextArea.redo())

Where does this libplasma5 domain come from?

> documenthandler.cpp:94
>  
> +void DocumentHandler::paste()
> +{

This could  benefit from a name to explain the difference from the regular text 
edit paste.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to