apol added inline comments. INLINE COMMENTS
> ActionToolBar.qml:183 > + } > + return result; > } it could be `children: [].concat(root.actions).concat(hiddenActions);` no? > ActionToolBar.qml:207 > > - onObjectAdded: object.create() > - onObjectRemoved: object.remove() > + return ourAction.hasOwnProperty("visible") ? > ourAction.visible === undefined || ourAction.visible : true > } since it's boolean, you can do: `visible: !actionsLayout.isActionVisible(ourAction) && (ourAction.visible === undefined || ourAction.visible)` REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23502 To: ahiemstra, #kirigami, mart Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, davidedmundson, mart, hein