gikari added inline comments.

INLINE COMMENTS

> broulik wrote in fonts.cpp:607
> Are you sure `parent` is a `QGuiApplication`? I don't think so. Perhaps you 
> want to connect to `QGuiApplication::instance()` instead.

Just tested. It works. So the plan is to remove explicit call from the font kcm 
and replace it with that signal binding? For fonts it sure will work, but what 
about other settings, that will be in the future, like color schemes, icons 
etc? Whose signals we will receive?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Reply via email to