ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
In D24193#537123 <https://phabricator.kde.org/D24193#537123>, @ouwerkerk wrote: > If Kirigami is supposed to depend on Qt 5.11, then *why* were these old imports there in the first place? They cannot work with Qt 5.11, because then the max QQC version is 2.4 > > Maybe I am misunderstanding something here? Are you saying the old Kirigami code effectively broke its own policy on depending on (newer) Qt versions? Yes, D22974 <https://phabricator.kde.org/D22974> broke this policy. The correct fix is D24147 <https://phabricator.kde.org/D24147>. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24193 To: ouwerkerk, mart, #plasma, ngraham Cc: ngraham, anthonyfieroni, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein