anthonyfieroni added inline comments.

INLINE COMMENTS

> slidefiltermodel.cpp:140
>          std::iota(m_randomOrder.begin(), m_randomOrder.end(), 0);
>          std::random_shuffle(m_randomOrder.begin(), m_randomOrder.end());
>      }

random_shuffle is removed in C++17, so maybe we can change to
`std::shuffle(m_randomOrder.begin(), m_randomOrder.end(), rand);`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24985

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to