mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed.
After that it seems ok for me INLINE COMMENTS > globalaccel.cpp:25 > + kmenueditGroup = KConfigGroup(&khotkeysrc, > QStringLiteral("Data_%1").arg(i)); > + if (kmenueditGroup.readEntry("Name", QString()) == > QStringLiteral("KMenuEdit")) { > + foundKmenuedit = true; QLatin1String("...") it's a minor optimization ---------------------------------------------- > globalaccel.cpp:38 > + // only migrate the launch actions for now, not the default search > action > + if (KConfigGroup(&khotkeysrc, groupName).readEntry("Type") != > QStringLiteral("MENUENTRY_SHORTCUT_ACTION_DATA")) { > + continue; same here REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart