ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch exposes a UI for choosing what happens when you left-click in the 
scroll trough
  in a Qt or KDE app. The default behavior is unchanged (left-click to page 
up/page down)
  but now you can choose to warp the scroll handle straight to the clicked 
position.
  
  Having this setting in the Workspace KCM opens the door to later making it 
also change
  the behavior for GTK apps as well, allowing us to remove one more setting 
from the GTK
  KCM and bringing us one step closer to finishing T10611: Set options for GTK 
apps in the respective KCMs <https://phabricator.kde.org/T10611>.
  
  BUG: 379498
  FIXED-IN: 5.18.0
  
  Depends on D25360 <https://phabricator.kde.org/D25360>

TEST PLAN
  F7768893: New option.png <https://phabricator.kde.org/F7768893>
  
  - Apply D25360 <https://phabricator.kde.org/D25360>
  - Click on "Scrolls to the clicked location" in the KCM
  - Click in the scroll trough in a Qt/KDE app
  - See that the scroll handle position jumps right there
  - Click on  "Scrolls one page up or down" in the KCM
  - Click in the scroll trough in a Qt/KDE app
  - See that the scroll handle moves up or down by one page height

REPOSITORY
  R119 Plasma Desktop

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: ngraham, #plasma, #vdg
Cc: gikari, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to