davidedmundson added inline comments.
INLINE COMMENTS
> constants.js:23
> +
> +var State = {
> + Idle: 0,
Why doesn't this come from the plugin?
> main.qml:111
> + if (monitor.state == Constants.State.ContentIndexing) {
> + return i18n("Currently indexing: %1 ",
> monitor.filePath)
> + } else {
Is the space after %1 deliberate?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D25447
To: ngraham, #vdg, #plasma, #baloo, bruns
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n,
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, domson, ashaposhnikov,
spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart
