apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision.
REVISION SUMMARY We are discarding the value if there's no weights which meant that when setting a button to "", the text provided by mnemonicLabel wouldn't update. This patch changes it so it only skips the weights computation if there's no text. TEST PLAN Tested with patch that removes the text of some buttons when the screen is smaller on Discover. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D25618 AFFECTED FILES src/mnemonicattached.cpp To: apol, #kirigami, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein