filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision.
REVISION SUMMARY I added a top separator for QML applet configuration windows in D20908 <https://phabricator.kde.org/D20908> This separator is the equivalent of KWin's separator, minus the highlight color. I have been regretting the decision to draw it ever since the patch was comitted and believe it to be wrong for several reasons: - it's an infrigment on user choice: it doesn't respect the fact the user has turned off KWin's titlebar separator - it's inconsistent with qwidgets: there is no top separator there - it's degrades the goal of trying to have a uniform appearance between the window manager and window in the case of Breeze Light and Breeze Dark because it distinctly points out the titlbar - it's superfluous (not visible) when used with the default color scheme anyway With this patch only the sidebar is enclosed, which solves all of the points above with the exception of the second one (which just warrants this patch be replicated for qwidgets) REPOSITORY R119 Plasma Desktop BRANCH no-unwanted-titlebar-separator (branched from master) REVISION DETAIL https://phabricator.kde.org/D25728 AFFECTED FILES desktoppackage/contents/configuration/AppletConfiguration.qml To: filipf Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
