davidedmundson added a comment.
I can't really object, as you're just following the existing code, but I
don't really understand why we're doing this.
INLINE COMMENTS
> urlgrabber.cpp:106
> - KConfigGroup cg(KSharedConfig::openConfig(), "Actions");
> - if(!cg.readEntry("EnableMagicMimeActions",true)) {
> //qCDebug(KLIPPER_LOG) << "skipping mime magic due to configuration";
if (!KlipperSettings::enableMagicMimeActions())
without any other changes would do the same thing and be just as fast. The
KConfigSkeletonItem keeps the value locally without reading every time.
REPOSITORY
R120 Plasma Workspace
BRANCH
fix-enableMagicMimeActions (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25310
To: trmdi, #plasma, ngraham, apol
Cc: davidedmundson, ngraham, plasma-devel, #plasma, LeGast00n,
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
ahiemstra, mart
