ngraham added a comment.
In D25728#572362 <https://phabricator.kde.org/D25728#572362>, @manueljlin wrote: > I though that would just affect every app's titlebar without actually checking if the app has a toolbar, etc etc and just add/remove the divider everywhere and be done with it. However, if the app can actually send a hint to Kwin to make it hide or show the divider depending if it has a toolbar or not (or maybe through a window / app rule), then it's great Exactly. We can't rely 100% on KWin to draw the separator because with our proposed redesign, we want to have the separator below the menu or toolbar, if those are present. That means they would need to drawn by the app or the widget toolkit, not the window manager. That means that we can't have KWin always draw or not draw the titlebar. That means we need to have the separator drawn here. However there are two caveats that I can accept: - Right now this is the only kind of window that gains a separator drawn by the content view itself, so we should either turn it off or add it to all other windows with only titlebars - We should make the content view not draw the titlebar when KWin is drawing it Maybe what we should do is change the titlebar separator color in Breeze to be a pleasant dark gray like in the screenshot in @flipwise's latest comment instead of a garish blue, turn it on by default, and remove this here. Then for Plasma 6 (or whenever we do the proposed Breeze evolution) we can revisit that implementation and come up with something smarter. Does that make sense? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
