ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision.
REVISION SUMMARY Before this patch, the outline of the rubberband selection control was down and to the right half a pixel too far. This wasn't visible at 1x scaling because of the lack of antialiasing, but resulted in the top/left being too thin and bottom/right being too thick on high DPI displays. To fix the issue, I enabled antialiasing and moved all sides inwards by half a pixel so that the outline would be pixel perfect. I also added a function to get a QRectF with the correct size and position for rectangles with pen strokes. TEST PLAN - Open dolphin and make a selection with the mouse - Go to a Folder View Plasma widget and make a selection with the mouse REPOSITORY R31 Breeze BRANCH fix-rubberband (branched from master) REVISION DETAIL https://phabricator.kde.org/D26001 AFFECTED FILES kstyle/breezehelper.cpp kstyle/breezehelper.h kstyle/breezestyle.cpp To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
