mvourlakos added a comment.
This commit needs to be split in different commits.
Based on the approach I wil describe the issues of the commit and in what
changes I can approve or not.
SPLITTED COMMITS
1. The showLatteSettingsDialog() is used from more places and you have
changed its behavior. The page that
this function takes is used as the first page to show when the window is
created, after that it toggles between
tabs. This is used ALSO from [Meta+W] global shortcut and Latte trademark
icon in Dock Settings in order to show
the Latte Global Preferences. From my understanding you need to create a new
function that is not a toggler but
rather sets specific settings tab all the time
2. The context menu changes MUST be the same in TWO different places, because
otherwise showing context menu will be different between tasks and applets.
a. containmentactions/contextmenu/menu.cpp
b. plasmoid/package/contents/ui/ContextMenu.qml
3. Renames
a. Layouts->Configure TO Layouts->Manage...
b. Dock Settings -> Edit Dock...
c. Latte Global Settings... -> Application Settings....
4. Order:
a. -separator-
b. Layouts->
c. Application Settings...
d. Add Widgets...
e. Edit Dock...
f. -separator- [only for Tasks plasmoid]
g. Close... [only for Tasks plasmoid]
REPOSITORY
R878 Latte Dock
REVISION DETAIL
https://phabricator.kde.org/D26238
To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
