ervin added a comment.
In D26323#585291 <https://phabricator.kde.org/D26323#585291>, @meven wrote: > In D26323#585271 <https://phabricator.kde.org/D26323#585271>, @ervin wrote: > > > One nitpick to address before pushing. > > > > Also I mark those accepted assuming there will be another phase where the settings objects will actually be properly matched to the GUI. Currently it's all fixing the isDefaults by hand based on GUI state but not on config state. > > > Given the current GUI entanglement and the CfpPlugin split, I wonder about the opportunity given how much rewrite/refactoring will be necessary to use the KConfig state. I think it's worth it in any case, otherwise we fix symptoms but not the root cause and issues will creep up again later on when someone touches the module and forgets one of the error prone construct (like checking for mutability and enabling/disabling corresponding widgets, removing keys which are back to defaults from the config file, etc.). >> I don't think it currently honors the mutability state of those keys. This will need being addressed in further commits. > > Indeed, it will follow. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26323 To: meven, ervin, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
