ivan requested changes to this revision.
ivan added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> davidedmundson wrote in fetchsqlite.cpp:100
> There's an optimisation available here

This can be made much better by providing a custom range object to iterate from 
`keyValueBegin()` to `keyValueEnd()` - converting to `std::map` is quite 
inefficient.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26438

To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to