mart added inline comments.

INLINE COMMENTS

> image.cpp:554
> +
> +        if (wallpaperDir.mkpath(wallpaperDir.absolutePath()) && 
> !url.fileName().isEmpty()) {
> +            KIO::FileCopyJob *job = KIO::file_copy(url, 
> QUrl::fromLocalFile(wallpaperPath), -1, KIO::HideProgressInfo | 
> KIO::Overwrite);

this is for first run when ~/.local/share/wallpapers isn't there yet?

> image.cpp:555
> +        if (wallpaperDir.mkpath(wallpaperDir.absolutePath()) && 
> !url.fileName().isEmpty()) {
> +            KIO::FileCopyJob *job = KIO::file_copy(url, 
> QUrl::fromLocalFile(wallpaperPath), -1, KIO::HideProgressInfo | 
> KIO::Overwrite);
>  

I would prefer it to ask before owerwriting

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26525

To: trmdi, #plasma
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

Reply via email to