leinir added a comment.
In D26544#591398 <https://phabricator.kde.org/D26544#591398>, @ngraham wrote: > Since D26543 <https://phabricator.kde.org/D26543> is listed as a dependent, but it's in Frameworks, and Plasma 5.18 is going to depend on Frameworks 5.66, but 5.66 has already been tagged, that means that this can't land in 5.18, so we'll ship 5.18 with only the Global Themes KCM using the new dialog, and all the other dialogs using the old one. :/ Gah, i was under the impression the awkwardness with frameworks dependencies on the CI was due to Plasma requiring head... > Is D26543 <https://phabricator.kde.org/D26543> a hard blocker, or just a nice-to-have bugfix? Right, the functionality would all still exist (that is, install/uninstall/update/whatnot would function just fine), what would happen without the dependent patch is that the views will be out of sync with the system state (basically the onChangedEntriesChanged will just fail to call the function it's pointed at due to incompatible types, in all but the desktoptheme kcm (which just calls load anyway, which doesn't expect anything weird). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
