gvgeo planned changes to this revision. gvgeo added a comment.
In D26880#599939 <https://phabricator.kde.org/D26880#599939>, @filipf wrote: > I also just noticed a pre-existing bug - that the hover effect filling the mouse area doesn't work well when the icon is smaller: > > F7923931: Screenshot_20200123_190024.png <https://phabricator.kde.org/F7923931> > > The icon overflows the hover effect. I'm going to have the effect fill the icon instead: > > F7923933: Screenshot_20200123_185958.png <https://phabricator.kde.org/F7923933> I will rebase on this patch and make icon aware of the orientation. Otherwise highlight area will overlap with the blue-bar on top when horizontal. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26861 To: gvgeo, #vdg, #plasma, hein, ngraham Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart