----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3548/#review4950 -----------------------------------------------------------
Ship it! to me sounds good - Marco On 2010-04-10 13:15:06, Alessandro Diaferia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3548/ > ----------------------------------------------------------- > > (Updated 2010-04-10 13:15:06) > > > Review request for Plasma, Aaron Seigo, Marco Martin, and Christophe Olinger. > > > Summary > ------- > > This is a pretty huge patch but what it does is really simple. I just moved > MediaLayout and MediaHandler to the libs/ level. This is due to the fact that > (imho correctly) Christophe is trying to move the components layouting to the > states level. Having the layout class at the library level will allow this. > In addition to this i also changed the enum name from State to Mode since > having State both for the class names and for the enum was confusing. Anyway > i think we shouldn't use neither State nor Mode, but i don't have any idea at > the moment. So, please, if you have something in mind just shout out loud :-). > > Other changes you can find in this diff are just warning suppressions. > > > Diffs > ----- > > > /trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/CMakeLists.txt > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.h > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediahandler.h > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediahandler.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/medialayout.h > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/medialayout.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/CMakeLists.txt > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.h > PRE-CREATION > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp > PRE-CREATION > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.h > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/private/mediahandler.cpp > PRE-CREATION > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/private/mediahandler_p.h > PRE-CREATION > > /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/main.cpp > 1113305 > > /trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.cpp > 1113305 > > Diff: http://reviewboard.kde.org/r/3548/diff > > > Testing > ------- > > No regressions. > > > Thanks, > > Alessandro > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
