mart added inline comments.

INLINE COMMENTS

> volkov wrote in kirigamiplugin.cpp:173
> So, should it be registered for both versions 2.2 and 2.6?
> I tried to use revisions, but it looks like they don't work for properties of 
> attached property objects:
> https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions
> One can import kirigami 2.2 and use smallestFont.

Register it just for 2.2 and forget about revisions.
They're a broken concept and they will be removed in Qt6 anyways

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14562

To: volkov, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

Reply via email to