pino added inline comments.

INLINE COMMENTS

> main.cpp:42
> +    BaseMode::ApplicationMode mode = BaseMode::SystemSettings;
> +    if (executableName.endsWith(QLatin1String("kinfocenter"))) {
> +        binaryName = QStringLiteral("kinfocenter");

This will consider also `/usr/bin/my-kinfocenter` as kinfocenter, which is 
definitely not what you want.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27137

To: davidedmundson, #plasma, ngraham
Cc: pino, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to