ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ngraham wrote in ListItemBase.qml:120
> This feels wrong. The radio button shouldn't need a maximum width set on it.

Replace this line with `Layout.fillWidth: true`. This works because `soloLabel` 
and `defaultButton` will never be visible at the same time; when `soloLabel` 
isn't visible, then the radio button's label will be the item that's filling 
the width.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to