----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3780/ -----------------------------------------------------------
Review request for Plasma. Summary ------- this is the beginning of the activity manager. it's not very pretty yet; it doesn't have many features yet; but it's a start. switching between activities and creating new ones works. at the moment "activities" are still just containments; soon this will use the proper activity API instead. stuff that's not implemented yet: -responding to signals for anything other than added activities -showing a pretty thumbnail for each activity -start/stop/remove buttons -filtering Diffs ----- /dev/null PRE-CREATION /dev/null PRE-CREATION /dev/null PRE-CREATION /dev/null PRE-CREATION /dev/null PRE-CREATION /dev/null PRE-CREATION /dev/null PRE-CREATION /dev/null PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/desktop/shell/CMakeLists.txt 1115355 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.h 1115355 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.cpp 1115355 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.h 1115355 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.cpp 1115355 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1115355 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.h 1115355 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp 1115355 Diff: http://reviewboard.kde.org/r/3780/diff Testing ------- known issues: -removing a containment seems to crash ControllerWindow, because the destructor tries to use the containment's corona. I'm wondering if there's a way to fix this other than having ActivityManager store a pointer to the corona... of course it wouldn't be a problem if we could delete things off the scene without removing them first :/ -if you make the activitymanager or widgetexplorer go away without clicking the close button, its geometry is wrong the next time it's shown. not sure what's up with that. Thanks, Chani _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
