ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.
Just a nitpick, your call if you want to tackle it or not.
INLINE COMMENTS
> DeviceAutomounter.cpp:73
> + const QList<Solid::Device> volumes =
> Solid::Device::listFromType(Solid::DeviceInterface::StorageVolume);
> + for(Solid::Device volume : volumes) {
> // sa can be 0 (e.g. for the swap partition)
nitpick, feel free to ignore: would make sense to switch to a const ref here
since we're touching the line anyway. in the same vein, "const auto" on the
line before wouldn't be a bad idea either (if we ever switch to QVector for
instance it'd be one less place where compilation would break).
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D27052
REVISION DETAIL
https://phabricator.kde.org/D27052
To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
