apol added a comment.
LGTM otherwise INLINE COMMENTS > startup.cpp:422 > + m_process->setArguments(args); > + auto env = QProcessEnvironment::systemEnvironment(); > + env.insert(additionalEnv); only do it `if (!additionalEnv.isEmpty())` > startup.cpp:450 > + m_process->setArguments(args); > + auto env = QProcessEnvironment::systemEnvironment(); > + env.insert(additionalEnv); only do it if (!additionalEnv.isEmpty()) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27457 To: apol, #plasma, davidedmundson, fvogt Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
