ngraham added a comment.
In D24706#595764 <https://phabricator.kde.org/D24706#595764>, @ngraham wrote: > Thanks Noah. > > So you're the boss after all (as the de- facto Breeze maintainer now), and I think we should follow your lead design-wise. But it might also be interesting to have a discussion about what we want this to accomplish. > > Personally here's my wishlist: > > 1. Make it much more visually obvious which button is the default button > 2. Make the focused state look less like what most people would assume is the appearance for the default button > 3. Avoid making the focused state look too subtle > 4. Make the pressed state look more "pressed" > > I think this patch does #3 and #4, but not #1 or #2. However it's possible that the focus style you've chosen will be just fine once the selection effects look like this everywhere for consistency, and if the default button gets a stronger look. With the current state of the patch, IMO nothing has changed. The focused state still has more visual weighting than the "I'm a Default Button" state and still makes the background blue (with the default color scheme), so #1 and #2 are not achieved. #3 is still achieved, and #4 is improved by darkening the background for the pressed state, but IMO impaired by removing the gradient and the diagonal movement. I don't dislike the new focus appearance, but I think if we keep it like that, then the default button appearance needs to be made much stronger. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: mart, ahiemstra, cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, Orage, LeGast00n, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender
