ngraham added inline comments.

INLINE COMMENTS

> gtkconfig.h:89
>      void onKWinSettingsChange(const KConfigGroup &group, const 
> QByteArrayList &names) const;
> +    void onKcminputSettingsChange(const KConfigGroup &group, const 
> QByteArrayList &names) const;
>  

`onKcmInputSettingsChange` (capitalize the I in Input)

Maybe also capitalize KCM?

Or maybe call it `onCursorSettingsChange`

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27943

To: gikari, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to