cblack added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:367
> Just for my understanding: why is it necessary ? 
> Here at least, nothing changes if I take this out.

This causes Qt to request a background be drawn on these widgets, which is used 
for painting the border when there would normally be no widgets to paint on. 
Check systemsettings5 and spectacle.

> hpereiradacosta wrote in breezetoolsareamanager.cpp:108
> That's still needs fixing though. You cannot have things floating around 
> depending on which color scheme is used. right ? 
> There are many color schemes of all types in the wild. The widget style must 
> work for all.

This is intentional—if a window's titlebar and content colours are the same, 
the window is drawn as a homogeneous window instead of a window with a tools 
area.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to