apol added inline comments. INLINE COMMENTS
> PageRowGlobalToolBarUI.qml:49 > id: menuButton > - visible: !Kirigami.Settings.isMobile && > applicationWindow().globalDrawer && applicationWindow().globalDrawer.isMenu > !== "undefined" && applicationWindow().globalDrawer.isMenu > + visible: !Kirigami.Settings.isMobile && > applicationWindow().globalDrawer && applicationWindow().globalDrawer.isMenu > !== undefined && applicationWindow().globalDrawer.isMenu > icon.name: "application-menu" Wouldn't it be easier to do: visible: !Kirigami.Settings.isMobile && applicationWindow().globalDrawer && applicationWindow().globalDrawer.isMenu ? Otherwise we better check for the property with `"isMenu" in applicationWindow().globalDrawer` REPOSITORY R169 Kirigami BRANCH fixkamoso REVISION DETAIL https://phabricator.kde.org/D27996 To: nicolasfella, #kirigami, mart, ngraham Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ahiemstra, davidedmundson, mart
