broulik added inline comments.
INLINE COMMENTS
> kirigamiplugin.h:51
> #elif defined(KIRIGAMI_BUILD_TYPE_STATIC)
> - return filePath;
> + return QStringLiteral(":/org/kde/kirigami/") + path;
> #else
Doesn't that have to be `qrc` to be a valid URL?
> kirigamiplugin.h:58
> + {
> + return QUrl(resolveFileUrl(path)).toLocalFile();
> + }
You sure a `qrc` URL turns into a local path (or rather Qt's internal `:/`
magic path) like this?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D28068
To: nicolasfella, #kirigami, mart, keithzg, vkrause
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham,
apol, ahiemstra, davidedmundson, mart
