davidre added inline comments.

INLINE COMMENTS

> breezehelper.cpp:90
> +        _decorationConfig->load();
> +        if (qApp && qApp->property("KDE_COLOR_SCHEME_PATH").isValid()) {
> +            const auto path = 
> qApp->property("KDE_COLOR_SCHEME_PATH").toString();

I don't think you need such a big if. Loading a kconfig with empty string will 
load kdeglobals

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, 
niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to