ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in urlgrabber.h:185
> I think it's a silly way to do the port but okay, probably works and we get 
> to move on.

What is silly about it?

The original code in ClipCommandProcess used:
const QStringList matches = action.regExpMatches();
which was:
QStringList regExpMatches() const { return m_myRegExp.capturedTexts(); }

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-klipper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to