----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4082/#review5772 -----------------------------------------------------------
Ship it! needs some cleanup, but otherwise looks fine to me. /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp <http://reviewboard.kde.org/r/4082/#comment5422> unless text can be " ", this is the same as action->setToolTip(text) *shrug* /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp <http://reviewboard.kde.org/r/4082/#comment5425> personally i'd set hide to true. this would get rid of the else statements, needing only a hide = false in the one successful branch possible. /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp <http://reviewboard.kde.org/r/4082/#comment5423> the indentation of this looks very random. please use kdelibs coding style and consistent indentation. - Aaron On 2010-05-20 21:51:01, Nicolas Lécureuil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4082/ > ----------------------------------------------------------- > > (Updated 2010-05-20 21:51:01) > > > Review request for Plasma. > > > Summary > ------- > > This patch add tooltips when the user let the mouse on menu entries. > If the menu show Names, the tooltip display Description. > If the menu show Descriptions, the tooltip display Name > > This patch is from Rodrigo Goncalves de Oliveira > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp > 1128979 > > Diff: http://reviewboard.kde.org/r/4082/diff > > > Testing > ------- > > > Thanks, > > Nicolas > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
