ngraham added inline comments. INLINE COMMENTS
> screencaststream.cpp:374 > + notification->setTitle(i18n("Failed to start screencasting")); > + notification->setText(i18n("Error: %1").arg(body)); > + notification->setIconName(QStringLiteral("data-error")); `.arg` is unnecessary and in various cases can cause i18n() errors; just do it inline: `notification->setText(i18n("Error: %1", body));` Also for short strings like this, it's nice to add some context for translators. > screencaststream.cpp:385 > qCWarning(XdgDesktopPortalKdeScreenCastStream) << "Failed to create > PipeWire context"; > + emitFailureNotification(i18n("Failed to create PipeWire context")); > return; Are there more user-friendly and actionable strings we could for these error messages? I have no idea what this means specifically and would read it as "there was some gobbeldygook error." REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28517 To: cblack, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart